CRC checks (disable, please!)

Hi, Pix. Please help!!!
Can you disable some CRC checks from Lands of Lore (and may be some other games like Kyrandia in the future) to be able to run RUSSIAN translated versions?
We need to disable CRC checks for just "L01.PAK" in Lands of Lore engine ("GENERAL.PAK" and "VOC.PAK" are not affected in thanslation).
It was already done in ScummVM OG Edition (https://github.com/old-games/ScummVM-russian-translations-fork).

scummvm-1.7.0_OG_Edition_source/engines/kyra/detection.cpp

Code:


    //add ScummVM OG Edition
    // Russian fan translation (BETA)
    {
        {
            "lol",
            "CD",
            {
                { "GENERAL.PAK", 0, NULL, -1 },
                { "L01.PAK", 0, NULL, -1 },
                { 0, 0, 0, 0 }
            },
            Common::EN_ANY,
            Common::kPlatformDOS,
            ADGF_DROPLANGUAGE | ADGF_CD,
            GUIO7(GUIO_MIDIADLIB, GUIO_MIDIMT32, GUIO_MIDIGM, GUIO_MIDIPCSPK, GUIO_RENDERVGA, GAMEOPTION_LOL_SCROLLING, GAMEOPTION_LOL_CURSORS)
        },
        LOL_CD_FAN_FLAGS(Common::RU_RUS, Common::DE_DEU)
    },

    {
        {
            "lol",
            "CD",
            {

                { "GENERAL.PAK", 0, NULL, -1 },
                { "L01.PAK", 0, NULL, -1 },
                { 0, 0, 0, 0 }
            },
            Common::FR_FRA,
            Common::kPlatformDOS,
            ADGF_DROPLANGUAGE | ADGF_CD,
            GUIO7(GUIO_MIDIADLIB, GUIO_MIDIMT32, GUIO_MIDIGM, GUIO_MIDIPCSPK, GUIO_RENDERVGA, GAMEOPTION_LOL_SCROLLING, GAMEOPTION_LOL_CURSORS)
        },
        LOL_CD_FAN_FLAGS(Common::RU_RUS, Common::DE_DEU)
    },

    {
        {
            "lol",
            "CD",
            {
                { "GENERAL.PAK", 0, NULL, -1 },
                { "L01.PAK", 0, NULL, -1 },
                { 0, 0, 0, 0 }
            },
            Common::RU_RUS,
            Common::kPlatformDOS,
            ADGF_DROPLANGUAGE | ADGF_CD,
            GUIO7(GUIO_MIDIADLIB, GUIO_MIDIMT32, GUIO_MIDIGM, GUIO_MIDIPCSPK, GUIO_RENDERVGA, GAMEOPTION_LOL_SCROLLING, GAMEOPTION_LOL_CURSORS)
        },
        LOL_CD_FAN_FLAGS(Common::RU_RUS, Common::DE_DEU)
    },
    //add end


I can't say I'm too keen as it's not a project that holds much interest for me (not being a Russian speaker and all that). However, it's probably easy and I've been thinking about doing a 1.7 android build so I could combine the jobs. You'll have to wait a while though - I'll be off work for a week and in the house all day Wednesday so I'll take a look then.

Pix wrote:...it's not a project that holds much interest for me...

It's sad, 'cause it's the greatest mod for SCUMM VM i know.
And so much time you spent to dump games music.
By the way, i don't undesttand WHY that mod is illegal (so, your modifications can't be included in main SCUMM VM fork), because of all MIDIs from games if free online and dumped music is only for legal owners of these games.

In any case, i'm happy you are back and waitng your mods for 1.7.0 and CRC fixes. THANK YOU!

PS: is it possible to remove CRC-checks for Android and PSP builds too (old versions)?

I was referring specifically to the Russian translations although I do largely regard this project as done. I might start working on it again if I ever get a tablet.

I'm not planning on looking at the older versions so it's just going to be Android and Windows builds on 1.7.

Pix wrote:I was referring specifically to the Russian translations although I do largely regard this project as done. I might start working on it again if I ever get a tablet.

I'm not planning on looking at the older versions so it's just going to be Android and Windows builds on 1.7.

But PSP is still actual too, especially because of PSP don't have software synth emulator for MT-32 or SC and your mod is a great solution to listen best quality music in games.

As far as I know you are the only person who ever uses it which doesn't give me much incentive to spend hours setting up a PSP build environment again. I may have a look if I have enough time but it's seriously unlikely - the code is always there if you want to do this yourself. If I do any more builds I'll look at doing the Pandora first as I'm more likely to use that build myself.

I've moved everything over to 1.7, done some rudimentary testing, and am currently waiting for a release build to compile. This could take a while on this PC but the new build will be at http://www.pixsoriginadventures.co.uk/scummvm/scummvm-1.7.0-win32.rar fairly soon if you want to try it out. I've cut and paste the LOL translation code exactly as supplied but have no way to test it.

I'm definitely going to attempt Android and Pandora builds of this but it won't be today. Setting up development environments for these will take a while and the machine I'm on right now isn't even up to running a Unix virtual machine. If those go OK, I'll probably have a look at PSP but I make no promises. I'm not sure if 1.7 will even compile on PSP.

Thank you, Pix, you are the best! And we already got your fixes in old-games.ru edition of ScummVM_v1.7.0_OG_Edition(+Pix_Hacks) too!